Skip to content
This repository has been archived by the owner on Oct 8, 2021. It is now read-only.
This repository has been archived by the owner on Oct 8, 2021. It is now read-only.

Listview with initially hidden items breaks when refreshed - jQM 1.3.0 #5680

Closed
GodsBest opened this issue Feb 22, 2013 · 7 comments
Closed

Comments

@GodsBest
Copy link

In jQM 1.3.0 if a listview with initially hidden items is updated by adding new items and then calling .listview( 'refresh' ), the listview breaks. The newly added items do not hide.
http://jsfiddle.net/fiddleyetu/ffMhk/2/
If you comment out the last two lines of the javascript and click run, you'll see that it works as expected.

However, if the entire listview (including ul or ol element) is dynamically created by putting the dynamically generated listview markup in a container element and then calling .trigger( 'create' ) on the container element. it works fine.
http://jsfiddle.net/fiddleyetu/ffMhk/

@jaspermdegroot
Copy link
Contributor

Test page that uses latest code: http://jsbin.com/edeluh/68
This is something for the listview widget review.

@gabrielschulhof
Copy link

Actually, I would argue that, like, #6911, this is part of providing correct backwards compatibility with 1.3.0, and therefore the milestone should be 1.4.x.

@gabrielschulhof
Copy link

OK, I misunderstood. This never worked in the first place. Still, since it's a bug in 1.4.x, we should fix it. The fix does not require any refactoring. It's simply a bug fix.

@GodsBest
Copy link
Author

GodsBest commented May 2, 2014

Just to be sure we're on the same page issue #5680 remains unresolved to date:
http://jsbin.com/edeluh/68
http://jsfiddle.net/fiddleyetu/4gWXt/show/

What's the timeline for resolving it?

@jaspermdegroot
Copy link
Contributor

@gabrielschulhof - #7339 landed in 1.4-stable, right? Can we can close this ticket as fixed?

@gabrielschulhof
Copy link

Yeah, we can close it.

@gabrielschulhof
Copy link

Fixed in baa6932

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.