Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐞 Binary files are previewed as text files in Open Quickly and single file window #1797

Closed
plbstl opened this issue Jul 5, 2024 · 1 comment · Fixed by #1820
Closed

🐞 Binary files are previewed as text files in Open Quickly and single file window #1797

plbstl opened this issue Jul 5, 2024 · 1 comment · Fixed by #1820
Labels
bug Something isn't working triage needed

Comments

@plbstl
Copy link
Contributor

plbstl commented Jul 5, 2024

Description

The fix in #1707 did not include previewing files in Open Quickly and single file window.

Related to:

To Reproduce

Open Quickly:

  1. Open a folder containing an image in CodeEdit.
  2. Search for an image file in Open Quickly.
  3. Make sure the preview pane is expanded by toggling the icon in the right side of the Open Quickly modal.

open quickly preview toggle btn

Single file window:

  1. Drag and drop an image file on the CodeEdit dock icon

Expected Behavior

Non text files should be properly previewed in Open Quickly modal and single file window.

Version Information

CodeEdit: 0.1.0-alpha (38)
macOS: 14.5
Xcode: 15.4

Additional Context

No response

Screenshots

No response
@plbstl plbstl added the bug Something isn't working label Jul 5, 2024
@plbstl
Copy link
Contributor Author

plbstl commented Jul 5, 2024 •
edited
Loading

I can start working on this when #1790 is merged.

Edit: working on this.
@plbstl plbstl mentioned this issue Jul 23, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triage needed
1 participant
@plbstl