@nigelmegitt Can you provide a PR for the new settings flag?

@dsilhavy I could. Do we have any design documentation about how settings should be structured? I'm thinking that we would have settings.captions.enableRollUp and set it to true if absent to maintain current behaviour. Then any other captions-related settings would also go under settings.captions.

@dsilhavy I could. Do we have any design documentation about how settings should be structured? I'm thinking that we would have settings.captions.enableRollUp and set it to true if absent to maintain current behaviour. Then any other captions-related settings would also go under settings.captions.

We do have settings.streaming.text would it fit into that category:

  text: {
    defaultEnabled: true,
    extendSegmentedCues: true,
    webvtt: {
      customRenderingEnabled: false
    }
  }

Ah thanks I just found that too. Given that this is imscJS-specific, what do you think is best practice? Looks like maybe this would work:

settings = {
           ...,
           text: {
               defaultEnabled: true,
               extendSegmentedCues: true,
               imsc: {
                   enableRollUp: true,
               },
               webvtt: {
                   customRenderingEnabled: false
               }
           },
}

Ah thanks I just found that too. Given that this is imscJS-specific, what do you think is best practice? Looks like maybe this would work:

settings = {
           ...,
           text: {
               defaultEnabled: true,
               extendSegmentedCues: true,
               imsc: {
                   enableRollUp: true,
               },
               webvtt: {
                   customRenderingEnabled: false
               }
           },
}

That looks good thanks

I see that we have the same issue with displayForcedOnlyMode, so I'll add that in at the same time.

PR opened.

Tests?

Please advise if you think additional tests are needed, and if so, I'd appreciate hints about how to add them. I did not find an obvious location where these kind of settings could be tested; I'm also not sure how to go about testing roll-up mode since it is a content-dependent animation.

Testing displayForcedOnly is a bit easier, because in the presence of subtitles without itts:forcedDisplay="true", if that mode is set then no subtitles should display. However, if we are testing this then we should provide some alternate subtitles where itts:forcedDisplay="true" and check that in that case the subtitles do display.