Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instructive error message needed when Keystone v2 requires a firmware update to bind with MetaMask #20332

Open
danfinlay opened this issue Jul 31, 2023 · 2 comments

Comments

@danfinlay
Copy link
Contributor

danfinlay commented Jul 31, 2023

Describe the bug

I tried to connect a keystone wallet, but it says the QR code is invalid. This was related to the device needing a firmware update, as specified here

image

Steps to reproduce

  1. I'm not sure, I hadn't seen this before.
  2. "Connect hardware wallet"
  3. Select "Keystone"
  4. Show your Keystone QR code to the computer
  5. ???

Error messages or log output

In this situation we have an opportunity to provide a more instructive and actionable error message for v2 hardware.

Version

10.33.0-flask.0

Build type

Flask

Browser

Firefox

Operating system

MacOS

Hardware wallet

Keystone

Additional context

Btw, I'm not sure why the QR scanner is blurry. If I was scanning a private key, I could see how it would keep you safe against a screen recorder, but this handshake QR code only encodes the public address, which will already be shown on screen after a successful connection.

I scanned the QR code manually and it is the eth address that I want to connect.

If I could paste in the target address, it would both solve this issue and provide a watch-address feature.

@plasmacorral
Copy link
Contributor

plasmacorral commented Aug 1, 2023

@danfinlay Can you please confirm what version of the Keystone firmware you are using?

Keystone is currently offering v12.2 at https://keyst.one/firmware

I can confirm that I had no issue today pairing a new Keystone address to 10.33.0-flask.0 in Firefox 116 on mac with Keystone firmware v10.8.

@plasmacorral plasmacorral added needs-information Needs additional information from the user who reported the issue Sev2-normal Normal severity; minor loss of service or inconvenience. labels Aug 1, 2023
@plasmacorral
Copy link
Contributor

This was confirmed to be related to a required firmware update, and this information is divulged within the Keystone resources here. https://support.keyst.one/3rd-party-wallets/eth-and-web3-wallets-keystone/bind-metamask-with-keystone

However, I will change the ticket title here and add the enhancement label. We have an opportunity to provide a more instructive error message for anyone using Keystone v2. We do not anticipate that this issue will be present with hardware revision 3.

@plasmacorral plasmacorral changed the title [Bug]: Keystone QR code invalid Aug 17, 2023
@plasmacorral plasmacorral added type-enhancement ux-enhancement and removed type-bug needs-information Needs additional information from the user who reported the issue Sev2-normal Normal severity; minor loss of service or inconvenience. labels Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment