Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reimplement eventSource handling using thebelab logic #82

Merged
merged 1 commit into from
Aug 14, 2018
Merged

Reimplement eventSource handling using thebelab logic #82

merged 1 commit into from
Aug 14, 2018

Conversation

SamLau95
Copy link
Owner

Fixes #81.

This commit removes the Image.js file and instead implements all
BinderHub logic in BinderHub.js.

We've followed the implementation in
https://github.com/minrk/thebelab/blob/58fcf92d23000810d0db3ad3af46cfa700423530/src/thebelab.js#L323-L374
which hopefully fixes our EventSource woes.

Eventually, we'll just import thebelab and use their implementation for
requesting Binder servers.
@SamLau95
Reimplement eventSource handling using thebelab logic
543a856 
Fixes #81.

This commit removes the Image.js file and instead implements all
BinderHub logic in BinderHub.js.

We've followed the implementation in
https://github.com/minrk/thebelab/blob/58fcf92d23000810d0db3ad3af46cfa700423530/src/thebelab.js#L323-L374
which hopefully fixes our EventSource woes.

Eventually, we'll just import thebelab and use their implementation for
requesting Binder servers.
@SamLau95
Copy link
Owner Author

Reminder to self to ping jupyterhub/mybinder.org-deploy#624 to unban nbinteract-image.
@SamLau95 SamLau95 mentioned this pull request Aug 14, 2018
Merged
@SamLau95 SamLau95 merged commit 75e26ee into master Aug 14, 2018
@SamLau95 SamLau95 deleted the eventsource-fix branch August 14, 2018 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
1 participant
@SamLau95