feat: apex audit #82
Merged
feat: apex audit #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR will trigger a minor release when merged. |
solaris007
reviewed
Jan 17, 2024
| } | ||
| } | ||
|
|
||
| export function toggleWWW(baseUrl) { |
There was a problem hiding this comment.
could be replaced with:
Suggested change
| export function toggleWWW(baseUrl) { | |
| export function toggleWWW(baseUrl) { | |
| return baseUrl.replace(/^(https:\/\/)(www\.)?/, (match, p1, p2) => `${p1}${p2 ? '' : 'www.'}`); | |
| } |
There was a problem hiding this comment.
this is very elegant but I think the current version is easier to read than trying to understand what's going on with the anonymous function there
solaris007
approved these changes
Jan 17, 2024
solaris007
pushed a commit
that referenced
this pull request
Jan 17, 2024
# [1.6.0](v1.5.12...v1.6.0) (2024-01-17) ### Features * apex audit ([#82](#82)) ([2e79a37](2e79a37))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please ensure your pull request adheres to the following guidelines:
Related Issues
Thanks for contributing!