[#4851] fix: make TestHiveTableOperations setup independently
#4854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LindaSummer
changed the title
TestHiveTableOperations setup independent
|
@mchades would you please help to review the code? |
mchades
approved these changes
Sep 5, 2024
|
@mchades |
I think so. We can backport to branch-0.6. |
github-actions bot
pushed a commit
that referenced
this pull request
Sep 5, 2024
<!--
1. Title: [#<issue>] <type>(<scope>): <subject>
Examples:
- "[#123] feat(operator): support xxx"
- "[#233] fix: check null before access result in xxx"
- "[MINOR] refactor: fix typo in variable name"
- "[MINOR] docs: fix typo in README"
- "[#255] test: fix flaky test NameOfTheTest"
Reference: https://www.conventionalcommits.org/en/v1.0.0/
2. If the PR is unfinished, please mark this PR as draft.
-->
### What changes were proposed in this pull request?
`TestHiveTableOperations` can be tested before `TestHiveTable`
initialized.
Make `TestHiveTableOperations::steup()` run alone.
### Why are the changes needed?
When we try to just run `gradle :catalogs:catalog-hive:test --tests
'org.apache.gravitino.catalog.hive.TestHiveTableOperations'`,
`TestHiveTableOperations` needs static variables which must be
initialized ahead, and it can't be run alone.
Fix: #4851
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Refactor of unit test setup, local unit tests have passed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
TestHiveTableOperationscan be tested beforeTestHiveTableinitialized.Make
TestHiveTableOperations::steup()run alone.Why are the changes needed?
When we try to just run
gradle :catalogs:catalog-hive:test --tests 'org.apache.gravitino.catalog.hive.TestHiveTableOperations',TestHiveTableOperationsneeds static variables which must be initialized ahead, and it can't be run alone.Fix: #4851
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Refactor of unit test setup, local unit tests have passed.