Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Float Rounding in linechart.go "B" instead of "M" for 1e6 #258

Closed
danieldjewell opened this issue Oct 28, 2021 · 1 comment · Fixed by #259
Closed

Float Rounding in linechart.go "B" instead of "M" for 1e6 #258

danieldjewell opened this issue Oct 28, 2021 · 1 comment · Fixed by #259

Comments

@danieldjewell
Copy link

Hi!

I think there is a bug in linechart.go (see below)... shouldn't the symbol for 1e6 be "M" and not "B"?

cointop/pkg/termui/linechart.go

Line 208 in b921c09

return fmt.Sprintf("%.4fB", x/1e6)

@lyricnz lyricnz mentioned this issue Oct 28, 2021
Merged
@lyricnz
Copy link
Collaborator

lyricnz commented Oct 28, 2021

You're right! Raised fix. Thanks!
@lyricnz lyricnz linked a pull request Oct 28, 2021 that will close this issue
Fix suffix on y-axis for Millions #259
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@lyricnz @danieldjewell