Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve trace name column tooltip #2304

Closed
Varorbc opened this issue Feb 19, 2024 · 4 comments · Fixed by #2499
Closed

Improve trace name column tooltip #2304

Varorbc opened this issue Feb 19, 2024 · 4 comments · Fixed by #2499
Labels
area-dashboard good first issue Good for newcomers help wanted Issue that is a good candidate for community contribution.
Milestone
preview 5 (Apr)

Comments

@Varorbc
Copy link
Contributor

Varorbc commented Feb 19, 2024

image
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Feb 19, 2024
@JamesNK
Copy link
Member

JamesNK commented Feb 19, 2024

Why do you want a trace ID column? A column takes up more horizontal space and we want to keep as much space as possible for the name and spans.
@Varorbc
Copy link
Contributor Author

Varorbc commented Feb 19, 2024

When I first saw this string, I didn't know what it meant, nor did I have any relevant prompts or explanations. It wasn't until I clicked on the relevant page that I guessed it might be a tracking ID
@JamesNK
Copy link
Member

JamesNK commented Feb 19, 2024 •
edited
Loading

Ok. An improvement to make here is give more detail in the tooltip. Something like:

Name: apiservice
Trace Id: ddfdterthnghjyuityretf

(note: trace id can be the full, non-truncated value)
@eerhardt eerhardt added area-dashboard and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Feb 23, 2024
@kvenkatrajan kvenkatrajan added the help wanted Issue that is a good candidate for community contribution. label Feb 27, 2024
@kvenkatrajan kvenkatrajan changed the title Add TraceId Column Feb 27, 2024
@kvenkatrajan kvenkatrajan added this to the GA milestone Feb 27, 2024
@davidfowl davidfowl modified the milestones: GA, Backlog Feb 28, 2024
@davidfowl davidfowl added the good first issue Good for newcomers label Feb 28, 2024
@davidfowl
Copy link
Member

@Varorbc if you want to send a PR for this feel free!
@Varorbc Varorbc mentioned this issue Feb 28, 2024
Merged
@davidfowl davidfowl modified the milestones: Backlog, preview 5 (Apr) Feb 28, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Apr 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-dashboard good first issue Good for newcomers help wanted Issue that is a good candidate for community contribution.
5 participants
@davidfowl @JamesNK @Varorbc @eerhardt @kvenkatrajan