Add support for endpoints defined in Kestrel config #4205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-app-model
dotnet-policy-service
bot
added
the
community-contribution
davidfowl
reviewed
May 17, 2024
davidebbo
commented
May 17, 2024
davidfowl
reviewed
May 17, 2024
davidfowl
reviewed
May 19, 2024
davidfowl
reviewed
May 20, 2024
davidebbo
commented
May 20, 2024
davidebbo
force-pushed
the
kestrel-config
branch
2 times, most recently
from
0eb6280
to
54c2305
Compare
Co-authored-by: David Fowler <davidfowl@gmail.com>
- Use either scheme or name for binding name - Set the transport even in Runtime mode
davidfowl
approved these changes
Jun 3, 2024
|
Thanks @davidebbo ! |
|
So, as the person who originally raised this.. |
|
The change is in, but I don't know when it'll make it in some official build, @davidfowl are there daily builds people can get? @fergalmoran or you could just build the repo and try it there, if only to verify that it works as you expect. |
|
Docs here on using the daily builds https://github.com/dotnet/aspire/blob/main/docs/using-latest-daily.md |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow endpoints to be defined in the Kestrel config as an alternative to the profile. As is the case at runtime, Kestrel config endpoints override profile endpoints.
Fixes #3456
Microsoft Reviewers: Open in CodeFlow