-
-
Notifications
You must be signed in to change notification settings - Fork 141
-
-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migration script for expected types in EventCatalog on updates #796
Comments
This PR add these dependencies to EC and create a test emulating the package on production ( But, i think we could go a step further. The way i see, EC is two projects - the eventcatalog bin and astro project. The But, how do you distinguish the packages needed for each one? By separating the EC into two projects with workspaces, resulting in the following structure:
The final package would be the bin bundled by tsup along with its dependencies and the astro directory to copy/paste into the user's .eventcatalog-core directory. |
Yeah interesting @carlosallexandre I think you might be ontop something here. Happy to explore it in more details, what would the workspaces look like? Would we need to use turbo or anything? Or just plain workspaces? |
@boyney123 I think just plain workspaces. I will work on something more concrete by this weekend to show you. |
Use Case
When new packages are added to EventCatalog (lodash for example), the types are also added. Now EventCatalog will bundle the lodash package fine, but people will miss the types as they dev dependency.
We either, add them add project dependencies or write a script to add them to folks dev deps for them when they run the dev command for example.
I'm leaning towards making them a dep of the project....
Proposed Solution
No response
Implementation Notes
No response
Community Notes
The text was updated successfully, but these errors were encountered: