Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature request] Ground Projected Skybox #4372

Closed
mj321 opened this issue Jul 18, 2023 · 4 comments
Closed

[Feature request] Ground Projected Skybox #4372

mj321 opened this issue Jul 18, 2023 · 4 comments
Labels
type: feature New feature or request

Comments

@mj321
Copy link

mj321 commented Jul 18, 2023

I'd like to see support for the "ground projected skybox" from three.js in model-viewer

https://threejs.org/examples/webgl_materials_envmaps_groundprojected.html
https://github.com/mrdoob/three.js/blob/master/examples/webgl_materials_envmaps_groundprojected.html

It would open up new use cases.
@elalish
Copy link
Collaborator

elalish commented Jul 19, 2023

Agreed, that could be cool. Interested in trying a PR? I'd be happy to review and help with any questions.
@elalish elalish added the type: feature New feature or request label Jul 19, 2023
@mj321
Copy link
Author

mj321 commented Jul 24, 2023

Agreed, that could be cool. Interested in trying a PR? I'd be happy to review and help with any questions.

TBH, i wouldn't even know where to start :(
@phreak
Copy link

phreak commented Sep 23, 2023

Thinking further: if that ground projection would also be able to show animated graphics (for example seamless WEBPs), that could open a whole. world to the model viewer.
@elalish
Copy link
Collaborator

elalish commented Jan 11, 2024

Fixed by #4604
@elalish elalish closed this as completed Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature New feature or request
3 participants
@phreak @elalish @mj321