Skip to content
This repository has been archived by the owner on Oct 8, 2021. It is now read-only.
This repository has been archived by the owner on Oct 8, 2021. It is now read-only.

navbar link stays active when using changePage() #1181

Closed
dirkpennings opened this issue Mar 3, 2011 · 5 comments
Closed

navbar link stays active when using changePage() #1181

dirkpennings opened this issue Mar 3, 2011 · 5 comments
Labels
Component: Navbar
Milestone
1.3.0

Comments

@dirkpennings
Copy link

When using $.mobile.changePage() to navigate to your second internal linked page and going back through the back button, you see the clicked navbar link still has the class "ui-btn-active".

This unlike the normal internal linking functionality..

examples (click the "Bar" menu option):

normal, working: http://jsfiddle.net/dirkpennings/kt7VQ/

changePage, not working: http://jsfiddle.net/dirkpennings/EPUqj/
@toddparker
Copy link
Contributor

Updated the changePage example with latest:
http://jsfiddle.net/EPUqj/4/
@ghost ghost assigned johnbender Sep 22, 2011
@toddparker
Copy link
Contributor

@dirkpennings - Is this still an issue with 1.0.1?
Also please test on master (1.1-pre): www.jquerymobile.com/test
@jefftougas
Copy link

Still seems to be an issue.. Example with nightly build: http://jsfiddle.net/YkhQH/2/
@ghost ghost assigned jasondscott Jun 8, 2012
jasondscott pushed a commit to jasondscott/jquery-mobile that referenced this issue Jun 21, 2012
Fixes: jquery-archive#1181 - navbar link stays active when using chan…
f8abd04 
…gePage()

Clears the active button class on the pressed navbar button after a
pagechange.
This was referenced Sep 13, 2012
Closed
Closed
@polarfish
Copy link

Excuse me, I may not completely understand the process of releasing fixes, but when the fix of this bug will be released? In version 1.3.0? It's opened 2 years ago and still has "No milestone" label.
@jaspermdegroot jaspermdegroot mentioned this issue Feb 4, 2013
Merged
jaspermdegroot added a commit that referenced this issue Feb 4, 2013
@jaspermdegroot
Merge pull request #4579 from jasondscott/1181_ActiveNavBtn
64143ae 
Fixes: #1181 - navbar link stays active when using changePage()
@jaspermdegroot
Copy link
Contributor

Closing as fixed by 64143ae
@lentz lentz mentioned this issue Feb 27, 2013
Closed
jaspermdegroot added a commit that referenced this issue Apr 1, 2013
@jaspermdegroot
Navbar: Changed active state logic. Fixes #5707
70e2aed 
Removed workaround for #1181. Fixed that issue by addressing the actual cause: event.target returns ui-btn-inner instead of the anchor
jaspermdegroot added a commit that referenced this issue Apr 1, 2013
@jaspermdegroot
Navbar: Changed active state logic. Fixes #5707
440f7c0 
Removed workaround for #1181. Fixed that issue by addressing the actual cause: event.target returns ui-btn-inner instead of the anchor
jaspermdegroot added a commit that referenced this issue Apr 1, 2013
@jaspermdegroot
Navbar: make sure nav buttons with href="#" still get active state.
307ff5e 
This fixes a regression from the fix for #5707. That issue was a regression from the fix for #1181. I added the workaround for #1181 again but changed the event to avoid the regression.
jaspermdegroot added a commit that referenced this issue Apr 1, 2013
@jaspermdegroot
Navbar: make sure nav buttons with href="#" still get active state.
cf54b98 
This fixes a regression from the fix for #5707. That issue was a regression from the fix for #1181. I added the workaround for #1181 again but changed the event to avoid the regression.
This was referenced Apr 1, 2013
Closed
Closed
@jaspermdegroot jaspermdegroot mentioned this issue Aug 13, 2013
Closed
@jaspermdegroot jaspermdegroot mentioned this issue May 13, 2014
Closed
12 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Component: Navbar
7 participants
@johnbender @jefftougas @toddparker @dirkpennings @jasondscott @polarfish @jaspermdegroot