This repository has been archived by the owner on Oct 8, 2021. It is now read-only.
Table: Implement Classes Option #8349
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
November 19, 2015 12:38
Thus, replace it with an instance variable turned on at the beginning of _create() and turned off at the end of _create(). This removes the need for _refresh(). refresh() can now handle the actual refresh, and rebuild() becomes and alias for refresh(). We should deprecate rebuild() in favour of refresh().
This also speeds things up: http://jsperf.com/table-header-selector
Sometimes the column starts out as not visible, and sometimes it starts out as visible. Before making sure that .prop( "checked", false ) has no effect, the column must be rendered invisible irrespective of its starting state.
classes option and JSCS fun Fixes jquery-archivegh-8341
make table tests green WIP Fixes jquery-archivegh-8341
|
TODOS
|
remove extra test Fixes jquery-archivegh-8341
hasClasses in tests Fixes jquery-archivegh-8341
hasclasses and lacksclasses to table tests Fixes jquery-archivegh-8341
|
@arschmitz I think this is read for a round of review. Thanks! |
|
on it |
| this._on( this._menu, { | ||
| "change input": "_menuInputChange" | ||
| } ); | ||
| _updateVariableColumn: function( header, cells, priority/*, state */ ) { |
There was a problem hiding this comment.
remove unused stae var comment
|
A couple things i noticed throughout were use of jqmdata, jqmremovedata, and $.mobile.getAttribute all of which are deprecated. I also noticed there are not any backcompat tests over all looking good |
|
Oh and of course no hasClasses, but you have that as a todo already |
|
Related to tests it looks like this fixes the failures we are seeing in 1.5-dev on table but the |
post review changes Fixes jquery-archivegh-8341
|
gh-6531 needs to have the table-stripe removed |
test adjustments Fixes jquery-archivegh-8341
Closed
|
rebased fixed and landed on 1.5-dev |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes the changes made in the table review branch https://github.com/jquery/jquery-mobile/tree/7360-table-review