Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cull 6 point light projections separately #643

Open
guycalledfrank opened this issue Jun 17, 2016 · 3 comments
Open

Cull 6 point light projections separately #643

guycalledfrank opened this issue Jun 17, 2016 · 3 comments
Assignees
@mvaligursky
Labels
area: graphics Graphics related issue feature request

Comments

@guycalledfrank
Copy link
Contributor

Currently visible (at least partially) shadowed point lights always require to render the scene 6 times for each cubemap face, but we could cull each projection separately and skip some faces.
@guycalledfrank guycalledfrank self-assigned this Jun 17, 2016
@willeastcott
Copy link
Contributor

It looks like a point light does now cull the scene against each face of the shadow cubemap:

https://github.com/playcanvas/engine/blob/master/src/scene/forward-renderer.js#L1749

So I'm closing this. @guycalledfrank, if I've misunderstood something, please reopen. 😄
@guycalledfrank
Copy link
Contributor Author

I think what I meant was to cull 6 point light frustums by the camera frustum to skip some faces completely.
@guycalledfrank guycalledfrank reopened this Mar 4, 2018
@willeastcott willeastcott added the area: graphics Graphics related issue label Apr 15, 2020
@willeastcott
Copy link
Contributor

Reassigning this to you @mvaligursky since you've working in this area at the moment. Any thoughts?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: graphics Graphics related issue feature request
5 participants
@willeastcott @guycalledfrank @raytranuk @yaustar @mvaligursky