Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTTP response codes are not checked #162

Open
flit opened this issue Jan 31, 2021 · 1 comment
Open

HTTP response codes are not checked #162

flit opened this issue Jan 31, 2021 · 1 comment
Labels
bug

Comments

@flit
Copy link
Member

flit commented Jan 31, 2021 •
edited
Loading

Excluding status codes handled automatically by the reqwest crate, HTTP status code are not checked by CPM. Most importantly, this includes 4xx error responses like 404 Not Found. Whatever data the server sends in the response body is still saved to disk.

The location where the response status needs to be checked is here:

cmsis-pack-manager/rust/cmsis-pack/src/update/download.rs

Line 156 in 7afc424

.and_then(move |res| {

@flit flit changed the title Don't save .pack to disk on 404 response Aug 30, 2021
@flit flit added the bug label Aug 30, 2021
@flit flit mentioned this issue Aug 30, 2021
Open
@flit flit mentioned this issue Apr 12, 2022
Closed
@imi415 imi415 mentioned this issue Dec 21, 2022
Merged
@mbrossard
Copy link
Collaborator

Should we close this after #199 was merged?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug
2 participants
@mbrossard @flit