Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(explore): Misaligned column layout for Measures without time series data #4258

Open
briangregoryholmes opened this issue Mar 6, 2024 · 2 comments
Assignees
Labels
Type:Bug Something isn't working

Comments

@briangregoryholmes
Copy link
Contributor

On shorter browser windows, the layout of Measures in dashboards without time series data seems unintentional.

@jkhwu Do we have mocks for this state? There's a lot of manual calculation going in the component responsible for this, but I'm not sure where the justification came from.

Screenshot 2024-03-06 at 12 38 27 PM
@djbarnwal
Copy link
Member

Yeah, this hasn't been touched in a long time and has many regressions. We should re-do how we organize them. Previously the idea was to split them into n x m grid such that you don't have to scroll too much to see all the measures while also maintaining enough space for the leaderboards. Also we were trying to align the measure titles together i.e. if in a row we have 3 measures and one of them takes 2 lines for the title, we were trying to align all other titles in that row together. I feel for now maybe we can just use native css grid without worrying about precise alignment.

@jkhwu
Copy link
Contributor

jkhwu commented Mar 20, 2024

I don't currently have mocks for this state. If it's easier to maintain I would be ok with just doing a single column, left-aligned, of the bignum tiles. This might lay good groundwork for our upcoming 3-column layout concept.

@mindspank mindspank changed the title Dashboard: Misaligned column layout for Measures without time series data May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type:Bug Something isn't working
3 participants