Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python script import cleanup #2455

Open
joeyparrish opened this issue Mar 13, 2020 · 0 comments
Open

Python script import cleanup #2455

joeyparrish opened this issue Mar 13, 2020 · 0 comments
Labels
priority: P4 Nice to have / wishful thinking type: code health A code health issue
Milestone

Comments

@joeyparrish
Copy link
Member

We have a few problematic patterns in our build system. Although it all works as expected in context of the Shaka Player repo, we have private infrastructure tools that import these scripts, and in that context, things are messier. In particular, we are transitioning those tools to Python 3, which changed some import semantics.

The main issue seems to be local script names which conflict with module names:

  • "build.py" vs our "build" folder
  • "test.py" vs "test" module (python2 & python3)
  • "compiler.py" vs "compiler" module (python2 only)

I'm not sure if I've completely analyzed this, or what the best solution would be. Renaming things will create compatibility issues when using our tools during a git bisect.

@joeyparrish joeyparrish added the type: code health A code health issue label Mar 13, 2020
@joeyparrish joeyparrish added this to the Backlog milestone Mar 13, 2020
@joeyparrish joeyparrish added the priority: P4 Nice to have / wishful thinking label Oct 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: P4 Nice to have / wishful thinking type: code health A code health issue
1 participant