Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Future of the motion controls option #255

Open
romaricpascal opened this issue Oct 29, 2021 · 2 comments
Open

Future of the motion controls option #255

romaricpascal opened this issue Oct 29, 2021 · 2 comments

Comments

@romaricpascal
Copy link

Hi!

I've noticed that ThreeJS has removed the DeviceOrientationControls from their codebase. I was wondering which impacts (if any) it would have on videojs-vr continuing to support motion controls for viewing 360 videos?

@gkatsev
Copy link
Member

gkatsev commented Oct 29, 2021

It's definitely going to be an issue. We already don't really have the bandwidth to maintain this project. The last time I updated threejs (#249) I've had trouble and it potentially broke some things. I did vendor some files but I think it's a bit more complicated to get things updated for the future.

@Smidgens
Copy link

Smidgens commented Dec 1, 2021

It's definitely going to be an issue. We already don't really have the bandwidth to maintain this project. The last time I updated threejs (#249) I've had trouble and it potentially broke some things. I did vendor some files but I think it's a bit more complicated to get things updated for the future.

Is this something that could be offloaded to a separate package? Like if say, videojs-vr didn't come included with camera or motion controls, but provided some kind of plugin interface for people to implement or install their own?
I'm using three.js by itself in another project, and if I recall, I needed to copy and modify the default motion controls due to some niche platform issues I was having. I'm not sure how I'd go about doing something like that with videojs-vr at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants