-
Notifications
You must be signed in to change notification settings - Fork 656
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[css-grid-3] The initial value of masonry-slack
should be 0
#10882
Comments
I disagree, because of I think the default should be something that generally works well: and I suspect there are very, very few use cases where a value less than It's also easier to understand that there's a value you can tweak here when it isn't zero: the behavior is already there, so you go looking for the knob rather than assuming there isn't one.
|
Yeah, a 1px difference between two columns should definitely not cause the masonry items to be misordered by default; that would just be a bad default behavior. We can discuss exactly what value the default should be, but it should definitely be something non-zero but fairly small, approximately |
I really like the idea of I agree that's about the right amount — it's kind of the smallest visible difference. And of course, authors can change it. Maybe we want to do |
I have tested desandro's Masonry and Macy.js, and both definitely do that by default. I didn't even see an option to change this, so it doesn't seem something authors expect or are asking for (unlike #10883 btw). While I agree that using some positive value is desirable in most cases, I'm not convinced that the confusion that it may cause if we set
Yeah I guess that's a good point, though.
I don't see |
https://drafts.csswg.org/css-grid-3/#masonry-slack says that the initial is
masonry-slack: 1em
.I think that the correct
masonry-slack
slack value is very dependent on the contents of the masonry, so1em
may not work well in some cases, and will probably just cause unnecessary confusion to authors.I think it's better to default to 0, and then let authors choose what works best for them.
The text was updated successfully, but these errors were encountered: