Draft PR to get help with MQTT OTA update issue #4146
Draft
+2,349
−1,516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I can't show my full codebase, but these should be all the relevant changes for my OTA issue
|
Dear Lord.... 😄 Please undo all irrelevant/formatting changes if you want any advice. |
|
I agree with @blazoncek - I see lots of styling, but still no clue what your problem is about.
If you can't show your codebase (closed source) then we need to know at least if this PR provides a feature that will be useful in open source WLED? |
softhack007
reviewed
Sep 17, 2024
| @@ -11,7 +11,7 @@ | |||
|
|
|||
| # CI binaries | |||
| ; default_envs = nodemcuv2, esp8266_2m, esp01_1m_full, esp32dev, esp32_eth # ESP32 variant builds are temporarily excluded from CI due to toolchain issues on the GitHub Actions Linux environment | |||
| default_envs = nodemcuv2, esp8266_2m, esp01_1m_full, nodemcuv2_compat, esp8266_2m_compat, esp01_1m_full_compat, nodemcuv2_160, esp8266_2m_160, esp01_1m_full_160, esp32dev, esp32_eth, esp32dev_audioreactive, lolin_s2_mini, esp32c3dev, esp32s3dev_8MB, esp32s3dev_8MB_PSRAM_opi | |||
There was a problem hiding this comment.
Please undo all changes to platformIO.ini.
softhack007
added
the
rebase needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making this draft PR so I can get help with an issue I'm running into while trying to add remote OTA updates over mqtt.
I can't show my full codebase, but these should be all the relevant changes for my OTA issue