Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[OSRS] Adds display names to Options #3954

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[OSRS] Adds display names to Options #3954

wants to merge 1 commit into from
+35 −0

Conversation

digiholic
Copy link
Collaborator

What is this fixing or adding?

closes #3946 , adds display names to OSRS options

How was this tested?

Web Host run locally, confirmed display names added.

If this makes graphical changes, please attach screenshots.

image
@github-actions github-actions bot added the waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. label Sep 17, 2024
@Exempt-Medic Exempt-Medic added the is: enhancement Issues requesting new features or pull requests implementing new features. label Sep 18, 2024
Exempt-Medic
Exempt-Medic approved these changes Sep 18, 2024
View reviewed changes
Copy link
Collaborator

@Exempt-Medic Exempt-Medic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM in code and on a local WebHost.
agilbert1412
agilbert1412 approved these changes Sep 18, 2024
View reviewed changes
Copy link
Collaborator

@agilbert1412 agilbert1412 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Display names are good and consistent with each other.
@agilbert1412 agilbert1412 added waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer. and removed waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. labels Sep 18, 2024
nicholassaylor
nicholassaylor approved these changes Sep 18, 2024
View reviewed changes
Copy link
Contributor

@nicholassaylor nicholassaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good, does close the related issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is: enhancement Issues requesting new features or pull requests implementing new features. waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer.
4 participants
@digiholic @agilbert1412 @Exempt-Medic @nicholassaylor