Update changelog and minor tweaks

CesiumGS · Oct 13, 2022 · 1b9d5b3 · 1b9d5b3
1 parent 35a4340
commit 1b9d5b3
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/CHANGES.md b/CHANGES.md
@@ -1,5 +1,11 @@
 # Change Log
 
+### 1.99 - 2022-11-01
+
+##### Fixes :wrench:
+
+- Fixed a bug where the scale of a `Model` was being incorrectly applied to its bounding sphere. [#10855](https://github.com/CesiumGS/cesium/pull/10855)
+
 ### 1.98.1 - 2022-10-03
 
 - This is an npm only release to fix the improperly published 1.98.

diff --git a/Specs/Scene/Model/ModelSpec.js b/Specs/Scene/Model/ModelSpec.js
@@ -3291,7 +3291,7 @@ describe(
             );
             Matrix4.getTranslation(expectedTranslation, expectedCenter);
 
-            let boundingSphere = model.boundingSphere;
+            const boundingSphere = model.boundingSphere;
             expect(boundingSphere.center).toEqual(
               Cartesian3.multiplyByScalar(
                 expectedCenter,
@@ -3305,12 +3305,12 @@ describe(
             );
 
             model.scale = 0.0;
-            boundingSphere = model.boundingSphere;
+            scene.renderForSpecs();
             expect(boundingSphere.center).toEqual(Cartesian3.ZERO);
             expect(boundingSphere.radius).toEqual(0.0);
 
             model.scale = 1.0;
-            boundingSphere = model.boundingSphere;
+            scene.renderForSpecs();
             expect(boundingSphere.center).toEqual(expectedCenter);
             expect(boundingSphere.radius).toEqualEpsilon(
               expectedRadius,