silenced build warnings.

Corvusoft · Jul 12, 2017 · 468788c · 468788c
1 parent 3d45a5f
commit 468788c
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 17 deletions.
diff --git a/source/corvusoft/protocol/detail/http_impl.hpp b/source/corvusoft/protocol/detail/http_impl.hpp
@@ -154,7 +154,7 @@ namespace corvusoft
                     return 0;
                 }
 
-                static std::size_t compose_request( core::Bytes& data, const std::shared_ptr< Message >& message, std::error_code& error )
+                static std::size_t compose_request( core::Bytes& data, const std::shared_ptr< Message >& message )
                 {
                     data = message->get( "request:method" );
                     data.emplace_back( ' ' );
@@ -181,7 +181,7 @@ namespace corvusoft
                     return data.size( );
                 }
 
-                static std::size_t compose_response( core::Bytes& data, const std::shared_ptr< Message >& message, std::error_code& error )
+                static std::size_t compose_response( core::Bytes& data, const std::shared_ptr< Message >& message )
                 {
                     data = message->get( "response:protocol" );
                     data.emplace_back( '/' );
@@ -208,7 +208,7 @@ namespace corvusoft
                     return data.size( );
                 }
 
-                static std::size_t compose_header( core::Bytes& data, const std::pair< const std::string, const core::Bytes >& property )
+                static void compose_header( core::Bytes& data, const std::pair< const std::string, const core::Bytes >& property )
                 {
                     const auto& name = property.first;
                     data.insert( data.end( ), name.begin( ), name.end( ) );
@@ -221,7 +221,7 @@ namespace corvusoft
                     data.emplace_back( '\n' );
                 }
 
-                static std::size_t compose_body( core::Bytes& data, const core::Bytes& value )
+                static void compose_body( core::Bytes& data, const core::Bytes& value )
                 {
                     data.emplace_back( '\r' );
                     data.emplace_back( '\n' );

diff --git a/source/corvusoft/protocol/http.cpp b/source/corvusoft/protocol/http.cpp
@@ -60,8 +60,6 @@ namespace corvusoft
             return error_code( );
         }
 
-        //mention in documentation this only reads to the start of body!
-        //add list arguemnt for parse and compose.
         error_code HTTP::parse( const shared_ptr< Adaptor > adaptor, const shared_ptr< Message > message ) noexcept
         {
             if ( adaptor == nullptr ) return make_error_code( std::errc::invalid_argument );
@@ -83,7 +81,6 @@ namespace corvusoft
                 return make_error_code( std::errc::wrong_protocol_type );
 
             //adaptor->purge( length, error );
-
             return error;
         }
 
@@ -92,7 +89,6 @@ namespace corvusoft
             return error_code( );
         }
 
-        //mentioned the reserved words in message message, path, etc...
         error_code HTTP::compose( const shared_ptr< Adaptor > adaptor, const shared_ptr< Message > message ) noexcept
         {
             if ( adaptor == nullptr ) return make_error_code( std::errc::invalid_argument );
@@ -103,9 +99,9 @@ namespace corvusoft
             size_t length = 0;
 
             if ( m_pimpl->uppercase( message->get( "request:protocol" ) ) == "HTTP" )
-                length = m_pimpl->compose_request( data, message, error );
+                length = m_pimpl->compose_request( data, message );
             else if ( m_pimpl->uppercase( message->get( "response:protocol" ) ) == "HTTP" )
-                length = m_pimpl->compose_response( data, message, error );
+                length = m_pimpl->compose_response( data, message );
             else
                 return std::make_error_code( std::errc::wrong_protocol_type );
 

diff --git a/source/corvusoft/protocol/message.cpp b/source/corvusoft/protocol/message.cpp
@@ -48,15 +48,10 @@ namespace corvusoft
         void Message::erase( const string& name )
         {
             auto& properties = m_pimpl->properties;
-            properties.erase(
-                remove_if( properties.begin( ), properties.end( ),
-                           [ &name ]( const auto & property )
+            properties.erase( remove_if( properties.begin( ), properties.end( ), [ &name ]( const auto & property )
             {
                 return property.first == name;
-            }
-                         ),
-            properties.end( )
-            );
+            } ), properties.end( ) );
         }
 
         vector< pair< string, Bytes > > Message::get( void ) const