hi textview placeholder position

[jjljiang155]

I try to add textview in view

[daniel-jonathan]

Hi, please add more details, code, and the actual problem you are facing. Thank you! We would be happy to help when we have that information. Until, I will close this issue.

[jjljiang155]

my code let textview1 = TextView() textview1.placeholder = "请输入原因" textview1 font = UIFont.systemFont(ofSize: 14) self.addSubview(textview1) override func layoutSubviews() { super.layoutSubviews() textView.frame = bounds } In TextView ,I fond this code The height of the placeorder lable minimumTextHeight = 35 h = max(h, minimumTextHeight) h = min(h, bounds.height - insets.top - insets.bottom) by minimumTextHeight 在 2019-08-24 21:14:40，"Daniel Jonathan" <notifications@github.com> 写道： Closed #1256. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

[daniel-jonathan]

I will reopen this issue, and we will take a look at it this week, latest next week. Thank you!

[adamdahan]

@nodle-J @DanielDahan I see the issue..

[adamdahan]

@nodle-J thank you for your patience - I will keep this ticket up until we have a fix. 👍

[OrkhanAlikhanov]

@adamdahan is this happening only when we have Chinese characters?

[adamdahan]

@OrkhanAlikhanov So far, yes.

[jjljiang155]

It is Font less than 17 ,I think
In TextView
func layoutPlaceholderLabel()
var h = placeholderLabel.sizeThatFits(CGSize(width: w, height: .greatestFiniteMagnitude)).height
h = max(h, minimumTextHeight)
h = min(h, bounds.height - insets.top - insets.bottom)
placeholderLabel.frame = CGRect(x: leftPadding, y: insets.top, width: w, height: h)

I don't understand h， I set font less than 17 but minimumTextHeight is constant 。

I canceled this code .

h = max(h, minimumTextHeight)
h = min(h, bounds.height - insets.top - insets.bottom)

Its all right

I have just learned swift
if I am wrong,please forgive me

thanks

[adamdahan]

@nodle-J We have started an internal conversation to re-write this component. For now a simple fix would be to set the

Line 326.
  internal let minimumTextHeight: CGFloat = 0

For your specific use case.

We will push a fix soon that's more appropriate for everyone!

Thank you for submitting this issue and getting us to notice :)

[daniel-jonathan]

Linking the task issue: #1264

[jjljiang155]

I'd love to. Thank you very much At 2019-09-10 21:26:08, "Adam Dahan" <notifications@github.com> wrote: @nodle-J I have confirmed that this does indeed solve the issue with no reprocussions. Would you like to submit a pull request that removes lines 425 & 426 from TextView.swift? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.