Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix .nav-bar-header background color. #1286

Closed
wants to merge 1 commit into from

Conversation

niyari
Copy link
Contributor

@niyari niyari commented Jul 2, 2024

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • New feature or enhancement
  • UI change (please include screenshot!)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Internationalization and localization
  • Other (please describe):

What is the current behavior?

Issue Number: #1228

What is the new behavior?

  • Title bar is non colorized.
    image

Other information

note: The splash screen is not affected by this change.

Quality check

Before creating this PR:

  • Did you follow the code style guideline as described in CONTRIBUTING.md
  • Did you build the app and test your changes?
  • Did you check for accessibility? On Windows, you can use Accessibility Insights for this.
  • Did you verify that the change work in Release build configuration
  • Did you verify that all unit tests pass
  • If necessary and if possible, did you verify your changes on:
    • Windows
    • macOS
    • Linux
@veler
Copy link
Collaborator

veler commented Jul 3, 2024

Hi @niyari ,
Thanks for this PR. I think it can cause a problem for users who have the Show accent color on title bar and window borders option turned OFF in Windows Settings. It makes the title bar not having the Mica effect, because the color you defined hides it.

The change you suggest also affect Linux and MacOS, which we should avoid.

Here is a suggestion:

Instead of changing the CSS, let's change the MainWindow.xaml and add a Border behind the CustomBlazorWebView, placed at the top of the window.

This Border could conditionally have a color:

  1. When Show accent color on title bar and window borders is OFF, the Border should have a transparent background
  2. When ON, the Border should have the same color than the one defined in Windows Settings.

These links can be helpful:

@veler veler linked an issue Jul 14, 2024 that may be closed by this pull request
@veler
Copy link
Collaborator

veler commented Jul 14, 2024

Hey @niyari ,

Thanks again for your change proposal. I made a fix here that follows my suggestion: #1299

@veler veler closed this Jul 14, 2024
@niyari
Copy link
Contributor Author

niyari commented Jul 15, 2024

I think it would be nice to unify the app's colors, similar to Visual Studio.
However, I didn't have time to suggest this change.

@niyari niyari deleted the fix-1228 branch July 15, 2024 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants