Hide channel names on the Channel page #3956
Conversation
A la another website, it makes sense to not show the channel name every video when you are explicitly already perusing that channel's content.
github-actions
bot
added
the
PR: waiting for review
kommunarr
removed
the
PR: waiting for review
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
|
|
|
See description |
|
I have no idea if channel view support displaying special stuff like topic/auto generated channel etc. |
|
The only thing currently supported in FreeTube is topic channels which display playlists that can point to the real artist channel or have multiple authors (not supported by invidious or youtube.js, youtube.js uses the entire text but only the first link/id). |
|
This PR is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 14 days. |
|
This PR is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 14 days. |
|
So are we still waiting on more support on both API's? |
|
Pretty sure. It's reliant on the schema being returned by Invidious and youtube.js, which is probably subject to change to fix their parsing in the near future. The most likely change to this implementation is that we will have to pass a parent channel ID to hide, and filter the list of displayed channel IDs. If it ends up being that we don't have all of the IDs as the completed state for either of Invidious or youtube.js, we'll just have to do that with channel name. |
|
The only case we had in the past with content from other channels on a channel were albums and singles on the playlists tab on artist topic channels, but youtube has rearranged their layout, so currently we just have an empty playlists tab there. So yes now all sources of content from other channels being displayed on a channel require changes to be supported (again). |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Pull request was converted to draft
|
Drafted for the reason of, if I'm reading & remembering correctly, we can't currently properly identify the edge cases of multiple authors with either available backend, in which cases we don't want to block the author labels from being displayed. I don't feel confident enough in my grasp of the issue at this time to make PRs on YT.js or Invidious pertaining to the root of the underlying issue or to provide the exact action steps needed, but I can do so once I have cleared all of my higher priority tasks. |
Drafted for the reason of, if I'm reading & remembering correctly, we can't currently properly identify the edge cases of multiple authors with either available backend, in which cases we don't want to block the author labels from being displayed.
Hide channel names on the Channel page
Pull Request Type
Related issue
closes #3955
Description
Adds boolean determining whether channel names should be shown in a video list or playlist list, and sets it to true for Channel pages' Videos, Shorts, Playlists, and Live tabs.
Note: This should not be the behavior when there two or more one channel names being displayed on a channel, either throughout the listed videos or under any one given video. We may be able to parse these scenarios more cleanly with our Local API, but it is unlikely that we will be able to do so with data received from Invidious.
At this precise moment, FreeTube does not currently support any such case of multiple channels being displayed under one, but it is expected to in the future. It seems like a reasonable course of action to keep this PR in stasis until Invidious and/or our Local API adds fuller support for channels with multiple other channels displayed. Kudos to @absidue for communicating the relevant details and parameters of this problem.
Screenshots
Testing
Has been tested on multiple channels displaying at most one channel.
Desktop