-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/water waves #187
base: develop
Are you sure you want to change the base?
Feature/water waves #187
Conversation
I've tested this patch and it works. I made a local edit to autumn.xml in data to fill in the values @titison listed in this forum post. here are some demo videos: This uses the values titi_son suggested This uses the values |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
waves have same size in oceans and in rivers. Titi_son and me talked about it how to fix it. |
Cool. I'm looking forward to it |
Major Update to game. Proper Faction Name New Models Unit Rebalancing
Did you decide on how to fix this yet @titison and @titiger ? Looking at the code, it would be quite easy to make it dependent on the depth of the water. If you wanted to make it dependent on the depth and the area of the body of water (more accurate), this would be more difficult. I think the 2 modifications I'd make before merging this is make the wave amplitude and frequency depth dependent:
This might lead to weird looking waves in rivers with a deep trench, but I think it would be ok. |
Adding simple water waves to MegaGlest.
See https://forum.megaglest.org/index.php?topic=9949