Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Official logo inclusion #894

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from
Open

Official logo inclusion #894

wants to merge 8 commits into from

Conversation

Beak-man
Copy link
Member

@Beak-man Beak-man commented Apr 27, 2023

Description of the Change

Inclusion of the new WorldWind logo in the upper right corner to the library and the examples.

Why Should This Be In Core?

The purpose of this logo is to provide attributions to the WorldWind engine by default. It can be easily removed by the developer if desired.

Benefits

This logo can be toggled on or off, and it can be modified by the developer to show a different logo.

Potential Drawbacks

  • The CoordinatesDisplayLayer had to be modified to accommodate for the logo in narrow screens. This means that the coordinates will display with a bigger offset from the top of the screen if the screen is narrow, even if the logo display is turned off. This only affects users of narrow displays, such as cellphones.
  • The logo flickers in the second and third globes of the MultiWindow example. This flickering is shared with the Bing logo, even though the mechanisms to construct both differ. The implication is that this glitch wasn't introduced by this change.
@Beak-man Beak-man requested a review from markpet49 April 27, 2023 16:42
@Beak-man Beak-man self-assigned this Apr 27, 2023
PJHogan
PJHogan previously approved these changes Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants