Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise Splitbee events for the Google OAuth and deactivating account #410

Merged
merged 2 commits into from
Sep 5, 2022

Conversation

nsunami
Copy link
Collaborator

@nsunami nsunami commented Sep 5, 2022

This PR revises the Splitbee events for the Google OAuth, such that the events are now attached to the <a> tag.

This PR also adds Splitbee events for the deactivate account buttons.

@nsunami nsunami linked an issue Sep 5, 2022 that may be closed by this pull request
@nsunami nsunami marked this pull request as ready for review September 5, 2022 14:29
@nsunami nsunami temporarily deployed to postreview-nami-407-spl-vwi4du September 5, 2022 14:29 Inactive
Copy link
Collaborator

@jazellemaira jazellemaira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Always, improving! Great work asawa! ILY!👍

@jazellemaira jazellemaira merged commit 46519e0 into main Sep 5, 2022
@jazellemaira jazellemaira deleted the nami/407-splitbee-google branch September 5, 2022 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants