Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve bit manipulation algorithm implementations #788

Merged
merged 3 commits into from
Sep 16, 2024

Conversation

sozelfist
Copy link
Contributor

Changes made:

  • Add docstring to file and function
  • Rewrite tests using macro

Checklist:

  • I ran bellow commands using the latest version of rust nightly.
  • I ran cargo clippy --all -- -D warnings just before my last commit and fixed any issue that was found.
  • I ran cargo fmt just before my last commit.
  • I ran cargo test just before my last commit and all tests passed.
  • I added my algorithm to the corresponding mod.rs file within its own folder, and in any parent folder(s).
  • I added my algorithm to DIRECTORY.md with the correct link.
  • I checked COUNTRIBUTING.md and my code follows its guidelines.
- Add docstring to file and function
- Rewrite tests using macro
@codecov-commenter
Copy link

codecov-commenter commented Sep 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.33%. Comparing base (63c4430) to head (cd17c1b).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #788      +/-   ##
==========================================
- Coverage   95.34%   95.33%   -0.01%     
==========================================
  Files         310      310              
  Lines       22689    22657      -32     
==========================================
- Hits        21632    21600      -32     
  Misses       1057     1057              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sozelfist
Copy link
Contributor Author

Can you have a look, @vil02?

Note: the CI Clippy step failed because of the new stable rust version

@vil02
Copy link
Member

vil02 commented Sep 12, 2024

Note: the CI Clippy step failed because of the new stable rust version

This should be handled by #789.

@sozelfist sozelfist changed the title chore[clean_up]: Improve bit manipulation algorithm implementations Sep 12, 2024
src/bit_manipulation/highest_set_bit.rs Outdated Show resolved Hide resolved
src/bit_manipulation/sum_of_two_integers.rs Outdated Show resolved Hide resolved
src/bit_manipulation/sum_of_two_integers.rs Outdated Show resolved Hide resolved
src/bit_manipulation/counting_bits.rs Show resolved Hide resolved
@vil02 vil02 merged commit b2acfd2 into TheAlgorithms:master Sep 16, 2024
4 checks passed
@sozelfist sozelfist deleted the clean_up/bit_manipulation branch September 17, 2024 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants