fix: set dev source for psi (#117)

* chore: migrate renovate config * chore: remove esmock * fix: set psi x-source header with env * fix: test
adobe · Feb 2, 2024 · 3537fda · 3537fda
1 parent f50efe9
commit 3537fda
Show file tree

Hide file tree

Showing 4 changed files with 19 additions and 4 deletions.
diff --git a/src/lhs/handler.js b/src/lhs/handler.js
@@ -263,9 +263,17 @@ function initServices(config, log = console) {
     psiApiBaseUrl,
     sqs,
     dataAccess,
+    environment,
   } = config;
 
-  const psiClient = PSIClient({ apiKey: psiApiKey, apiBaseUrl: psiApiBaseUrl }, log);
+  const psiClient = PSIClient(
+    {
+      apiKey: psiApiKey,
+      apiBaseUrl: psiApiBaseUrl,
+      environment,
+    },
+    log,
+  );
 
   return {
     dataAccess,
@@ -346,6 +354,7 @@ export default async function audit(message, context) {
       psiApiBaseUrl,
       sqs,
       dataAccess,
+      environment: context.func.version === 'v1' ? 'prod' : 'dev',
     }, log);
 
     const startTime = process.hrtime();

diff --git a/src/support/psi-client.js b/src/support/psi-client.js
@@ -35,7 +35,7 @@ export const PSI_STRATEGIES = [PSI_STRATEGY_MOBILE, PSI_STRATEGY_DESKTOP];
  *  @return {PSIClient} - The PSI client.
  */
 function PSIClient(config, log = console) {
-  const { apiKey, apiBaseUrl } = config;
+  const { apiKey, apiBaseUrl, environment } = config;
 
   if (!isValidUrl(apiBaseUrl)) {
     throw new Error(`Invalid PSI API Base URL: ${apiBaseUrl}`);
@@ -72,7 +72,8 @@ function PSIClient(config, log = console) {
   const performPSICheck = async (baseURL, strategy) => {
     try {
       const apiURL = getPSIApiUrl(baseURL, strategy);
-      const response = await fetch(apiURL, { headers: { 'x-source': 'spacecat' } });
+      const xSource = `spacecat-${environment}`;
+      const response = await fetch(apiURL, { headers: { 'x-source': xSource } });
       if (!response.ok) {
         throw new Error(`HTTP error! Status: ${response.status}`);
       }

diff --git a/test/audits/lhs.test.js b/test/audits/lhs.test.js
@@ -85,6 +85,9 @@ describe('LHS Audit', () => {
     };
     context = {
       log: mockLog,
+      func: {
+        version: 'ci',
+      },
       runtime: {
         region: 'us-east-1',
       },
@@ -276,6 +279,7 @@ describe('LHS Audit', () => {
       .get('/?url=https%3A%2F%2Fadobe.com%2F&strategy=mobile')
       .reply(200, psiResult);
 
+    context.func.version = 'v1';
     context.sqs.sendMessage.rejects(new Error('SQS Error'));
 
     await audit(auditQueueMessage, context);

diff --git a/test/support/psi-client.test.js b/test/support/psi-client.test.js
@@ -29,6 +29,7 @@ describe('PSIClient', () => {
   const config = {
     apiKey: 'testApiKey',
     apiBaseUrl: 'https://example.com',
+    environment: 'dev',
   };
 
   beforeEach(() => {
@@ -79,7 +80,7 @@ describe('PSIClient', () => {
     it('fetches PSI data successfully', async () => {
       nock('https://example.com')
         .get('/')
-        .matchHeader('x-source', 'spacecat')
+        .matchHeader('x-source', 'spacecat-dev')
         .query(true)
         .reply(200, { lighthouseResult: { score: 0.9 } });