[Improve][Connector-V2] Optimize milvus code #7691
Open
+50
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hisoka-X
reviewed
Sep 19, 2024
Comment on lines
+351
to
355
| if (!tableExists(tablePath) && !ignoreIfNotExists) { | ||
| throw new TableNotExistException(catalogName, tablePath); | ||
| } | ||
| this.client.dropCollection( | ||
| DropCollectionParam.newBuilder() |
There was a problem hiding this comment.
if ignoreIfNotExists == true, why we should continue execute dropCollection?
| @@ -358,6 +361,9 @@ public void dropTable(TablePath tablePath, boolean ignoreIfNotExists) | |||
| @Override | |||
| public void createDatabase(TablePath tablePath, boolean ignoreIfExists) | |||
| throws DatabaseAlreadyExistException, CatalogException { | |||
| if (databaseExists(tablePath.getDatabaseName()) && !ignoreIfExists) { | |||
| @@ -372,6 +378,9 @@ public void createDatabase(TablePath tablePath, boolean ignoreIfExists) | |||
| @Override | |||
| public void dropDatabase(TablePath tablePath, boolean ignoreIfNotExists) | |||
| throws DatabaseNotExistException, CatalogException { | |||
| if (!databaseExists(tablePath.getDatabaseName()) && !ignoreIfNotExists) { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
Optimized milvus connector part code logic
Does this PR introduce any user-facing change?
How was this patch tested?
Check list
New License Guide
release-note.