fix: OpenSearch import errors #2939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeonLuttenberger
requested review from
kukushking,
malachi-constant and
jaidisido
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
malachi-constant
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detail
If a customer has
opensearchpyinstalled but notjsonpath_ng, the import of awswrangler will fail. This goes against our current protocol, which is that we throw an appropriate import error when the customer tries to invoke a method which requires an optional dependency.The
jsonpath_ngdependency is also only required for certain cases when loading JSON data, so I'm only appending the annotation to the_get_documents_w_json_pathfunction.Issue
#2938
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.