i18n: add support for translation to markets #281
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes translation-support for markets without breaking support for existing markets/apps without translation-fields. The PR is based on my previous PR for general Translation-Support. #273
It's basically some additional checks to the json-fields coming from markets. If there is a translation available of the specific field, it'll show the translated value. It supports staged fallback from locale (f.e. de-CH) to language (f.e. de) to default
As the official market has no translated fields as of yet, you can test it with my fork, which is translated to de and de-CH:
https://github.com/aseracorp/resiSTORE
Feel free to request changes / improvements.
The PR expects the following structure for the description and cosmos-installer:
description.json