Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip: add version data #162

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

sousuke0422
Copy link
Contributor

@sousuke0422 sousuke0422 commented Mar 21, 2021

私のフォークの絵文字処理はv12と同等なので、v12と同じ処理をするようにしました。

task

  • 正規表現を書く
これは正攻法じゃない気がする・・・
@sousuke0422 sousuke0422 marked this pull request as ready for review April 4, 2021 02:37
@sousuke0422
Copy link
Contributor Author

とりあえず動くようにはなった

多分これで問題ない
@@ -60,6 +60,13 @@
}
]
},
"v11-rei0784":{
"id": "v11-rei0784",
"match_data": "^11\.*-rei0784-\..*$",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JSONパーサーに引っ掛かるので多分こうすれば引っ掛からなくなる。(バージョン判定大丈夫かはわからない。
"match_data": "^11\\.*-rei0784-\\..*$"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants