Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(snowflake): fixing the snowflake schema fetcher logic (#7440) #8665

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

christianallred-nomi
Copy link

@christianallred-nomi christianallred-nomi commented Sep 3, 2024

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Issue Reference this PR resolves

[For example #12]

Description of Changes Made (if issue reference is not provided)

[Description goes here]

@christianallred-nomi christianallred-nomi requested a review from a team as a code owner September 3, 2024 18:18
Copy link

vercel bot commented Sep 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

8 Skipped Deployments
Name Status Preview Comments Updated (UTC)
examples-angular-dashboard ⬜️ Ignored (Inspect) Visit Preview Sep 3, 2024 6:35pm
examples-react-d3 ⬜️ Ignored (Inspect) Visit Preview Sep 3, 2024 6:35pm
examples-react-dashboard ⬜️ Ignored (Inspect) Visit Preview Sep 3, 2024 6:35pm
examples-react-data-table ⬜️ Ignored (Inspect) Visit Preview Sep 3, 2024 6:35pm
examples-react-highcharts ⬜️ Ignored (Inspect) Visit Preview Sep 3, 2024 6:35pm
examples-react-material-ui ⬜️ Ignored (Inspect) Visit Preview Sep 3, 2024 6:35pm
examples-react-pivot-table ⬜️ Ignored (Inspect) Visit Preview Sep 3, 2024 6:35pm
examples-vue-query-builder ⬜️ Ignored (Inspect) Visit Preview Sep 3, 2024 6:35pm
@github-actions github-actions bot added the pr:community Contribution from Cube.js community members. label Sep 3, 2024
@christianallred-nomi christianallred-nomi force-pushed the fix(snowflake)fixing-undefined-case-in-snowflake branch 2 times, most recently from 85d3857 to 528129e Compare September 3, 2024 18:26
@christianallred-nomi christianallred-nomi force-pushed the fix(snowflake)fixing-undefined-case-in-snowflake branch from 528129e to e6f81bb Compare September 3, 2024 18:34
@igorlukanin
Copy link
Member

Hi @christianallred-nomi 👋

Thanks for your contribution! Do you think this is a breaking change?

@christianallred
Copy link

It should not be no.

A while ago snowflake made a decision to always cap case their responses. This caused an Outage for us. And is what causes the bug this or is aiming to fix with cube.

The fact that this is working for some snowflake users means they have this setting set globally instead of by session.

I liked this solution because it fixes the problem for affected users but should leave the existing users the same.

I have not had time to test this 100% however so if someone with a working snowflake instance can test it, that would be great:

@christianallred
Copy link

An alternate decision that would not require a session update would be to update the snowflake driver to overwrite the result parser function

@paveltiunov
Copy link
Member

@christianallred Thanks for contributing it! I think it's definitely great feature however as of now it should go under the flag which we'd enable by default going forward.

@christianallred
Copy link

@christianallred Thanks for contributing it! I think it's definitely great feature however as of now it should go under the flag which we'd enable by default going forward.

Whatever y'all decide is fine. It’s just broken for our use case until a fix is decided on. FWIW I don’t really have skin in the game anymore as I am leaving the org that was looking at cube as a solution. Cheers :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:community Contribution from Cube.js community members.
4 participants