Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cubesql): Support PERCENTILE_CONT SQL push down #8697

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MazterQyou
Copy link
Member

@MazterQyou MazterQyou commented Sep 11, 2024

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Description of Changes Made

This PR bumps DataFusion, allowing PERCENTILE_CONT aggregate function parsing and planning, and adds SQL push down templates for WITHIN GROUP expression. Related test is included.

@MazterQyou MazterQyou requested review from a team as code owners September 11, 2024 16:21
Copy link

codecov bot commented Sep 11, 2024

Codecov Report

Attention: Patch coverage is 82.47423% with 85 lines in your changes missing coverage. Please review.

Project coverage is 82.70%. Comparing base (ab3771b) to head (c16c562).

Files with missing lines Patch % Lines
...sql/cubesql/src/compile/rewrite/rules/old_split.rs 0.00% 61 Missing ⚠️
.../cubesql/src/compile/engine/df/optimizers/utils.rs 0.00% 20 Missing ⚠️
...ompile/rewrite/rules/wrapper/aggregate_function.rs 97.16% 3 Missing ⚠️
...t/cubesql/cubesql/src/compile/engine/df/wrapper.rs 94.11% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8697      +/-   ##
==========================================
+ Coverage   82.66%   82.70%   +0.03%     
==========================================
  Files         217      217              
  Lines       78125    78532     +407     
==========================================
+ Hits        64583    64946     +363     
- Misses      13542    13586      +44     
Flag Coverage Δ
cubesql 82.70% <82.47%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

vercel bot commented Sep 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

8 Skipped Deployments
Name Status Preview Comments Updated (UTC)
examples-angular-dashboard ⬜️ Ignored (Inspect) Visit Preview Sep 18, 2024 4:32pm
examples-react-d3 ⬜️ Ignored (Inspect) Visit Preview Sep 18, 2024 4:32pm
examples-react-dashboard ⬜️ Ignored (Inspect) Visit Preview Sep 18, 2024 4:32pm
examples-react-data-table ⬜️ Ignored (Inspect) Visit Preview Sep 18, 2024 4:32pm
examples-react-highcharts ⬜️ Ignored (Inspect) Visit Preview Sep 18, 2024 4:32pm
examples-react-material-ui ⬜️ Ignored (Inspect) Visit Preview Sep 18, 2024 4:32pm
examples-react-pivot-table ⬜️ Ignored (Inspect) Visit Preview Sep 18, 2024 4:32pm
examples-vue-query-builder ⬜️ Ignored (Inspect) Visit Preview Sep 18, 2024 4:32pm
@MazterQyou MazterQyou changed the title chore(cubesql): Support PERCENTILE_CONT planning Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
1 participant