Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] estimation using estimagic #1433

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

[WIP] estimation using estimagic #1433

wants to merge 6 commits into from
+1,521 −43

Conversation

alanlujan91
Copy link
Member

Please ensure your pull request adheres to the following guidelines:

  • Tests for new functionality/models or Tests to reproduce the bug-fix in code.
  • Updated documentation of features that add new functionality.
  • Update CHANGELOG.md with major/minor changes.
@alanlujan91 alanlujan91 requested a review from mnwhite May 23, 2024 13:52
@alanlujan91
Copy link
Member Author

currently failing because example notebook requires additional plotting libraries
@dedwar65
Copy link
Contributor

I've tried running the SMM notebook thats created in this PR. Apparently, estimagic has been renamed to optimagic. So far, this only amounts to importing estimagic and optimagic at the start of the code.

However, the notebook takes over 34 minutes to run the final estimate_msm command. Surely it didn't take this long before. Makes me wonder if this is related to the project change from optimagic to estimagic. I will keep trying to debug myself
@mnwhite
Copy link
Contributor

mnwhite commented Sep 19, 2024

Is this WIP or should be reviewed?
@alanlujan91
Copy link
Member Author

should be reviewed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Review Needed
3 participants
@alanlujan91 @dedwar65 @mnwhite