Update in_kafka_group.rb to fix the memory leak. #507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In kafka group plugin is leaking memory incase of kafka is not reachable and disable retry limit is true.
|
This PR has been automatically marked as stale because it has been open 90 days with no activity. Remove stale label or comment or this PR will be closed in 30 days |
ashie
requested changes
Jul 30, 2024
There was a problem hiding this comment.
Sorry for my late response.
Could you please address following 2 points?
- Probably just calling
retryis enough and better than callingreconnect_consumerrecursively as I've commented in-line. - Please follow DCO: https://github.com/fluent/fluent-plugin-kafka/pull/507/checks?check_run_id=21965716986
(Please addSigned-off-by:field to your commit message.)
| @@ -254,6 +255,9 @@ def reconnect_consumer | |||
| log.error "unexpected error during re-starting consumer object access", :error => e.to_s | |||
| log.error_backtrace | |||
| if @retry_count <= @retry_limit or disable_retry_limit | |||
| # Adding the following line to ensure, consumer object is cleaned before recursively calling reconnect_consumer. | |||
| # This ensures no memory leak. | |||
| consumer = nil | |||
| reconnect_consumer | |||
There was a problem hiding this comment.
Probably just calling retry here is better than resetting consumer and calling reconnect_consumer recursively.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In kafka group plugin is leaking memory incase of kafka is not reachable and disable retry limit is true.