set withCredentials for other loaders

[elalish]

Fixes #4083

This is a pretty straight-forward fix, but I don't have a great way to test it. @robertsLando I'd appreciate it if you can verify this is working for you once it's in.

[robertsLando]

@elalish Thanks for this but I just tested v3.0.0 and it's still not working 😢 Keep getting 403 error, this only happens with skybox image BTW, poster and model src are loaded with credentials correctly

[elalish]

Hmm, can you post a repro link?

[robertsLando]

@elalish I wish but I would need a repro with a backend to also authenticate the client, it's not that easy to create... I checked the code and your changes looks good I have no clue what it does differently, let me try to debug it on my end. Any tips?

[robertsLando]

This is the call stack when skybox image is loaded:

[robertsLando]

I think you should use loader.setWithCredentials(value) function instead of directly set the property, seems that setting it in this way the value isn't persisted to the parent instance, when it comes to the parent withCredentials is false but is true in hdrLoader and ldrLoader instances

[elalish]

Ah, good call! That's just a typo on my part, but I thought the @types/three would catch that kind of thing for me. Okay, should be an easy fix. Really appreciate the debug.

[robertsLando]

Perfect, Patch release please? :)

[elalish]

Yeah, probably - got a few other things to fix first.