Add pbr iridescence API #4348
Merged
Add pbr iridescence API #4348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elalish
reviewed
Jul 8, 2023
| return this[$backingThreeMaterial].iridescenceThicknessRange[1]; | ||
| } | ||
|
|
||
| get iridescenceThicknessTexture(): TextureInfo { |
There was a problem hiding this comment.
I just noticed this function signature doesn't match the API: one returns TextureInfo, while the other returns TextureInfo|null. I noticed because of the ! below. This is probably true of the rest as well - let's make sure we know which is correct and then make them match.
There was a problem hiding this comment.
Have these been added to the pbr map with createTextureInfo? Maybe we need something more type-safe than a map...
There was a problem hiding this comment.
yes, these are all added at $initialize
JL-Vidinoti
pushed a commit
to vidinoti/model-viewer
that referenced
this pull request
Apr 22, 2024
* Add pbr iridescence API * Make pbr next properties api consistent for TextureInfo * Add Anisotropy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows threejs implementation.