Blender Cycles Fidelity Test #4492

vis-prime · 2023-10-03T16:31:29Z

Fixes / Photos here : #4482

This script renders a exr file to the output directory.
Opens it & uses PILLOW to do ACES tonemaping.
Saves the final png & deletes the exr file.

The command :

blender -b -P test/renderers/blender-cycles/render.py -- {"scenario": {...}, "outputFile": "..."}

Command breakdown

blender is path to the blender executable , How do I mention it in the commit ? (3.6.4 or 4.X.X daily build )
-b is for background mode
-P runs the python script
test/renderers/blender-cycles/render.py is the path to the python file
and last part is the config json ( accessible under sys.argv[5] )

Current settings

128 samples (default: 4096 )
use GPU (default: CPU)
Importance sampling/Adaptive Sampling/Noise Threshold enabled (default: Enabled)
OpenImage Denoiser Enabled (default: Enabled)
colorspace Standard (default: 'AgX' in 4.X & "Filmic" in 3.X)"
exports a temp.exr (32bit ZIP codec) to the output dir

WSL on my windows system does not work on my old system, so npm install didn't work :-(
So I've replicated the changes from the V-Ray commit :-)
and to get outputs, I am running the script directly using the config.json

google-cla · 2023-10-03T16:31:33Z

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

bhouston · 2023-10-03T19:39:17Z

@vis-prime amazing! I'll try it out now. I think you need to side the Google CLA as mentioned above! It is super simple to do. :). I think it should use whatever Blender you have installed, so just the default Blender path I think is sufficient.

bhouston · 2023-10-03T19:55:58Z

It may be useful to have a README.md that describes how to set this up?

Are you using Blender directly, I guess you modify PYTHONPATH to point to somewhere inside of Blender, or are you compiling Blender as a Python Module? I assume as well you have to match the local Python version to Blender's python version, or are you using their python build directly?

This would help me reproduce.

vis-prime · 2023-10-04T15:09:50Z

alright! CLA done, will do a readme rehearsal here

Ensure you have Blender installed. You can either install the full version of Blender or extract the zip file to a location of your choice. (~350mb)
When running the script, provide the path to the Blender executable as the first argument.
The entire process utilizes Blender's internal Python module, so there should be no concerns about python version mismatches.
Note that PILLOW is not included in Blender's Python & gets automatically installed within the script.

So in my case with windows and blender 3.6

C:/Program Files/Blender Foundation/Blender 3.6/blender 
-b 
-P 
F:/net/model-viewer/packages/render-fidelity-tools/test/renderers/blender-cycles/render.py 
-- {"scenario": 
         {
             "lighting": "...", 
            "dimensions": {"width": 2048, "height": 1536}, 
            "target": {"x": 0, "y": 3.8, "z": 0}, 
            "orbit": {"theta": 0, "phi": 90,
             "radius": 20}, 
             "verticalFoV": 45, 
             "renderSkybox": true, 
             "name": "DirectionalLightTest", 
             "model": "....gltf", 
             "exclude": ["stellar"]
         }, 
         "outputFile": "..._cycles.png"
 }

extras

https://docs.blender.org/manual/en/latest/advanced/command_line/launch/index.html#command-line-launch-index

vis-prime · 2023-10-04T15:13:07Z

Previews (click to zoom in)

Image order: Cycles | Model Viewer | Three gpu pathtracer

elalish · 2023-10-04T15:22:23Z

Looking good! Mind signing our CLA and resolving the conflicts? Once these new goldens are uploaded we can look at merging this. Looking at CesiumMan and BrainStem it appears Blender is rendering these at their first animation frame instead of their resting pose - can you fix that in the python?

vis-prime · 2023-10-04T16:49:11Z

CesiumMan model notes

This and any models which have rigs/armature can be set into REST pose so it's no longer in frame 1 pose.
This model also has a icosphere mesh ,which automatically loads as hidden in the viewport but this mesh is still enabled for rendering so it shows up in the final render

(left: viewport | center: render output | right: node tree)

Should I hide this mesh in render too ? or leave it since this is the default behavior ?

elalish · 2023-10-04T17:08:17Z

I believe the sphere is a test, probably of unreferenced meshes and whether they get accidentally displayed or not. Since it loads as "hidden in viewport", it sounds like Blender is doing the right thing, so I think we can go ahead and use that as a sign to hide it in the Python render as well.

vis-prime · 2023-10-04T19:05:15Z

The ones which got fixed after

setting the armatures to REST state
hiding collections in render output which were hidden in viewport by default (the icospheres)

Brainstem is still messed up, I guess it lost its original/resting position when the frame 1 got applied

vis-prime · 2023-10-05T16:17:49Z

which one of these is correct ?

{
      "name": "blender-cycles",
      "description": "Blender's Cycles render engine",
      "command": {
        "executable": "python3",
        "args": [
          "blender",
          "-b",
          "-P",
          "test/renderers/blender-cycles/render.py"
        ]
      }
    }

or

{
     "name": "blender-cycles",
     "description": "Blender's Cycles render engine",
     "command": {
       "executable": "blender",
       "args": [
         "-b",
         "-P",
         "test/renderers/blender-cycles/render.py"
       ]
     }
   }

elalish · 2023-10-05T16:39:05Z

Hmm, I'm not sure about "correctness" if they both work, but

The entire process utilizes Blender's internal Python module, so there should be no concerns about python version mismatches.

makes me think that the second one is better, since the first might use your random system version of Python?

vis-prime · 2023-10-05T18:20:20Z

I haven't been able to test it with the npm run update-screenshots command

npm install fails cause WSL does not work (long story , need to buy a new laptop)

I've been just loading the config.json & running the script directly, so not sure if either of these commands are correct

@bhouston can you give it a go ?

bhouston · 2023-10-05T18:40:02Z

@vis-prime I will have a look!

julienduroure · 2023-10-05T20:09:16Z

I just fixed the sphere issue.
Should be available in tomorrow's build.

KhronosGroup/glTF-Blender-IO@fc2a7ae

The sphere is used for bone/joint shape, and should neither been seen in render

bhouston · 2023-10-05T20:34:31Z

The second method seems the most reasonable, run blender and give it a python script seems simplest. I may have suggested the first approach, but I think I was wrong earlier.

vis-prime · 2023-10-06T15:07:36Z

Yeah, fully executing the code directly via blender sounds good. Just have to make sure that all the file paths are still valid. (relative paths might not work)

Questions :

Should I remove my icosphere hiding code in favor of KhronosGroup/glTF-Blender-IO@fc2a7ae becoming live in blender 4.0 ?
and what are the next steps ? upload the goldens ?
I'm guessing there's no need to exclude any of the configs since it's good to have an visual feedback on unsupported features (like iridescence) ?

elalish · 2023-10-06T15:26:14Z

Yes
Yes
Correct, generally we exclude ones that crash or have some problem unrelated to glTF.

vis-prime · 2023-10-09T14:34:20Z

Some crucial changes are coming to GLTF & Principled v2 logic in the coming weeks (blender 4.0 releases in November)

Right now there are some material issues with using the 4.0 daily builds (KhronosGroup/glTF-Blender-IO#2014 (comment))

Is it better to wait for 4.0 release ?
or
Render the Golden's with the old principled bsdf from blender 3.6 and update it later ?

elalish · 2023-10-09T18:51:32Z

I'll defer to @bhouston since he's paying for the work, but since I don't see any particular time rush, I think it might be easier to wait for the 4.0 release.

julienduroure · 2023-10-26T21:11:21Z

Some crucial changes are coming to GLTF & Principled v2 logic in the coming weeks (blender 4.0 releases in November)

Changed are made. You should be able to get good render with 4.0 beta now.

vis-prime · 2023-10-27T15:40:34Z

awesome, looking good now!

I managed to get WSL2 working, there are still some puppeteer related errors when I run npm commands ,
but since this script does not need a browser, I'll try to run it via npm and see if the paths are valid/it works as expected
(these images were rendered directly using config.json)

image order : Model Viewer | THREE-GPU-Pathtracer | Cycles

elalish · 2023-10-27T16:27:02Z

Looking great! I can already see some bugs it's catching in Blender. You'll probably want to wait for some more of @bhouston's PRs to land so that you're updating the right scenarios.

elalish · 2023-11-09T16:50:54Z

Is this ready for review? It's still marked as draft.

vis-prime · 2023-11-14T18:09:45Z

blender 4.0 is out !
to install on linux : sudo snap install blender --classic

Tried wsl2 , no luck

Only thing i wanted to confirm was to check if blender was getting the full paths as arg and not the relative paths (as blender's python env might not have access to it)

The error i got while testing with wsl2

prime@vis:~/dev/model-viewer/packages/render-fidelity-tools$ npm run update-screenshots khronos-BoomBox blender-cycles

> @google/model-viewer-render-fidelity-tools@0.0.1 update-screenshots
> node --experimental-modules ./lib/workflows/update-screenshots.js ./test/config.json khronos-BoomBox blender-cycles

🆙 Updating screenshots
⏭  Skipping khronos-DragonAttenuation...
⏭  Skipping khronos-IridescentDishWithOlives...
⏭  Skipping khronos-ToyCar...
⏭  Skipping khronos-SheenChair...
⏭  Skipping khronos-MaterialsVariantsShoe...
blender-cycles: Rendering khronos-BoomBox...Error: Offline rendering process for Blender's Cycles render engine failed: [ALSOFT] (EE) Failed to set real-time priority for thread: Operation not permitted (1)

[notice] A new release of pip is available: 23.0.1 -> 23.3.1
[notice] To update, run: /snap/blender/4217/4.0/python/bin/python3.10 -m pip install --upgrade pip

    at updateScreenshots (file:///home/prime/dev/model-viewer/packages/render-fidelity-tools/lib/workflows/update-screenshots.js:130:31)
📋 Screenshot updates concluded
npm ERR! Lifecycle script `update-screenshots` failed with error: 
npm ERR! Error: command failed 
npm ERR!   in workspace: @google/model-viewer-render-fidelity-tools@0.0.1 
npm ERR!   at location: /home/prime/dev/model-viewer/packages/render-fidelity-tools

elalish · 2023-11-20T20:48:57Z

I'm not sure, but I'll let @bhouston guide this one.

vis-prime · 2023-11-25T17:17:27Z

Installed npm packages with WSL2
then on windows ran npm run update-screenshots khronos-BoomBox blender-cycles

and after fixing the relative path issue by doing a some path surgery , it still shows the error message but the render output is created correctly !

(another note : none of the python print statements,render progress messages or error messages show up on the terminal when running the update-screenshot command )

(in the video i'm using 12 samples to get the file quickly)

2023-11-23.13-19-18.mp4

vis-prime · 2023-12-10T16:35:41Z

on WSL2
ran the new npm run render-goldens -- --renderer=blender-cycles -m command

Image is generated correctly but there's an error at the end which stops the code, (so just ran the command multiple times to get the all the remaining goldens)

Image order : cycles | model-viewer

elalish · 2024-02-29T20:24:44Z

Sorry, I kind of lost track of this one. Should I go ahead and merge it? Appears to be complete now?

vis-prime · 2024-03-03T06:01:49Z

I'll just run/test the command in the latest blender version and let you know..

Can merge after that

Edit : should be okay to merge now

…dons/settings

elalish

Thank you!

* add cycles config * fix comments & typo * resolve conflict * armature `REST` pose and dont render hidden meshes * Readme & config update * config update , spread args with comma * remove icosphere hiding logic * images * convert relative to absolute paths * add new configs * blender add factory startup to prevent user interference from user addons/settings * update readme

vis-prime added 2 commits October 3, 2023 20:33

add cycles config

05f2df9

fix comments & typo

e8b5851

vis-prime and others added 2 commits October 4, 2023 21:00

resolve conflict

e02a439

Merge branch 'master' into blender-cycles

d3813af

vis-prime added 2 commits October 5, 2023 00:43

armature REST pose and dont render hidden meshes

186b553

Readme & config update

bc6dadf

config update , spread args with comma

5e12325

remove icosphere hiding logic

6a9b2a0

images

27b2e1e

vis-prime marked this pull request as ready for review November 14, 2023 17:58

convert relative to absolute paths

b877400

vis-prime and others added 2 commits December 9, 2023 18:54

Merge branch 'google:master' into blender-cycles

930edb5

add new configs

dcf6057

vis-prime added 2 commits March 3, 2024 17:57

blender add factory startup to prevent user interference from user ad…

f65495f

…dons/settings

update readme

b2cecc9

elalish approved these changes Mar 13, 2024

View reviewed changes

elalish merged commit 8a047c5 into google:master Mar 13, 2024
3 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Blender Cycles Fidelity Test #4492

Blender Cycles Fidelity Test #4492

vis-prime commented Oct 3, 2023 •

edited

Loading

google-cla bot commented Oct 3, 2023

bhouston commented Oct 3, 2023

bhouston commented Oct 3, 2023

vis-prime commented Oct 4, 2023 •

edited

Loading

vis-prime commented Oct 4, 2023 •

edited

Loading

elalish commented Oct 4, 2023

vis-prime commented Oct 4, 2023 •

edited

Loading

elalish commented Oct 4, 2023

vis-prime commented Oct 4, 2023 •

edited

Loading

vis-prime commented Oct 5, 2023

elalish commented Oct 5, 2023

vis-prime commented Oct 5, 2023

bhouston commented Oct 5, 2023

julienduroure commented Oct 5, 2023

bhouston commented Oct 5, 2023

vis-prime commented Oct 6, 2023 •

edited

Loading

elalish commented Oct 6, 2023

vis-prime commented Oct 9, 2023 •

edited

Loading

elalish commented Oct 9, 2023

julienduroure commented Oct 26, 2023

vis-prime commented Oct 27, 2023 •

edited

Loading

elalish commented Oct 27, 2023

elalish commented Nov 9, 2023

vis-prime commented Nov 14, 2023 •

edited

Loading

elalish commented Nov 20, 2023

vis-prime commented Nov 25, 2023 •

edited

Loading

vis-prime commented Dec 10, 2023

elalish commented Feb 29, 2024

vis-prime commented Mar 3, 2024 •

edited

Loading

elalish left a comment

Blender Cycles Fidelity Test #4492

Blender Cycles Fidelity Test #4492

Conversation

vis-prime commented Oct 3, 2023 • edited Loading

google-cla bot commented Oct 3, 2023

bhouston commented Oct 3, 2023

bhouston commented Oct 3, 2023

vis-prime commented Oct 4, 2023 • edited Loading

vis-prime commented Oct 4, 2023 • edited Loading

elalish commented Oct 4, 2023

vis-prime commented Oct 4, 2023 • edited Loading

elalish commented Oct 4, 2023

vis-prime commented Oct 4, 2023 • edited Loading

vis-prime commented Oct 5, 2023

elalish commented Oct 5, 2023

vis-prime commented Oct 5, 2023

bhouston commented Oct 5, 2023

julienduroure commented Oct 5, 2023

bhouston commented Oct 5, 2023

vis-prime commented Oct 6, 2023 • edited Loading

elalish commented Oct 6, 2023

vis-prime commented Oct 9, 2023 • edited Loading

elalish commented Oct 9, 2023

julienduroure commented Oct 26, 2023

vis-prime commented Oct 27, 2023 • edited Loading

elalish commented Oct 27, 2023

elalish commented Nov 9, 2023

vis-prime commented Nov 14, 2023 • edited Loading

elalish commented Nov 20, 2023

vis-prime commented Nov 25, 2023 • edited Loading

vis-prime commented Dec 10, 2023

elalish commented Feb 29, 2024

vis-prime commented Mar 3, 2024 • edited Loading

elalish left a comment

Choose a reason for hiding this comment

vis-prime commented Oct 3, 2023 •

edited

Loading

vis-prime commented Oct 4, 2023 •

edited

Loading

vis-prime commented Oct 4, 2023 •

edited

Loading

vis-prime commented Oct 4, 2023 •

edited

Loading

vis-prime commented Oct 4, 2023 •

edited

Loading

vis-prime commented Oct 6, 2023 •

edited

Loading

vis-prime commented Oct 9, 2023 •

edited

Loading

vis-prime commented Oct 27, 2023 •

edited

Loading

vis-prime commented Nov 14, 2023 •

edited

Loading

vis-prime commented Nov 25, 2023 •

edited

Loading

vis-prime commented Mar 3, 2024 •

edited

Loading