Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bug of computing oriented bounding box in tensor #6069

Merged
merged 1 commit into from
Jun 1, 2023

Conversation

qrcat
Copy link
Contributor

@qrcat qrcat commented Apr 7, 2023

An error occurs in computing oriented bounding box became the operation is absence of matrix transpose.
Therefore, the obb will just like an inverted box hence the bunny's ear is out of bbx.

An error

As the unit test has used a cube, the error could not be detected by programme automatically.

After fixing, the bounding box will be in a right place.

Unit test

Python usage


This change is Reviewable

@update-docs
Copy link

update-docs bot commented Apr 7, 2023

Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes.

@qrcat qrcat marked this pull request as draft April 7, 2023 08:08
@qrcat qrcat marked this pull request as ready for review April 7, 2023 08:09
@yuecideng yuecideng self-requested a review April 7, 2023 08:09
@ssheorey ssheorey merged commit e892d5b into isl-org:master Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants