This repository has been archived by the owner on Oct 8, 2021. It is now read-only.
Mark dialog as not open when it is closed even if put on its own page #5195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…. If this is not done it can cause strange behavior on the next page transition
|
I have applied this PR by hand, with slightly different formatting. Thanks! |
|
Thanks for a great framework! And for including this PR |
scottjehl
pushed a commit
that referenced
this pull request
Oct 31, 2012
* master: (24 commits) [select] Implement _destroy() -- Fixes #4661 Changing ok out to equal; it is more appropriate for this test Changing test to make sure it fails when code change is not there Renamed class ui-selectmenu-hidden to ui-popup-hidden -- Fixes #5217 [popup] Rename function _maybeRefreshTimeout to _expectResizeEvent [popup] "detached retina" fix - the window height on iStuff with a retina display seems to fluctuate by one pixel during scroll, causing a spurious resize event right after popup open, even though window size is constant during the entire opening sequence Added "mobileinit" handler to set up options Whitespace Changed urlParseRE to ignore space at beginning. This is expected behavior in browsers. This used to result in pages changing to "%20destination.html" instead of the now "destination.html". Fixes issue #4882 List autodividers: use trim() to avoid issues with newlines and spaces in markup. Fixes #5197. Thanks @demonslord ! [popup] Initiate resize expectation during orientationchange -- Fixes #5153 Select: headers of custom select menus shouldn't inherit the popup corner styling. Fixes #5215. [popup] Correctly handle the case when the fallback transition is "none" -- Fixes #5189 [custom select] Mark as closed after dialog closes - Re: #5195 - Thanks martenbohlin [slider] Adding new behaviour to widget definition [select] Adding new behaviour to widget definition [checkboxradio] Adding new behaviour to widget definition [formReset] New behaviour that allows form widgets to become aware of the fact that the form they are in has been reset [popup] Only rapid-open the popup if it is open -- Fixes #5157 Updated third-party libs for Backbone/Require Demo App ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If this is not done it can cause strange behaviour on the next page transition.
No test case is provided because i hade a real hard time reproducing the bad behaviour, it seemed to depend on the timing of the events on the page transition after the dialog is closed.