Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calendar: improve date getter/setter, add ARIA tests, clean up #1802

Merged
merged 5 commits into from
Apr 11, 2017

Conversation

fnagel
Copy link
Member

@fnagel fnagel commented Mar 31, 2017

No description provided.

@scottgonzalez
Copy link
Member

Looks good, but we need to handle the timezone issue. We can probably take a timestamp with an expected date/time and then compare the actual date/time and calculate an offset. Then add that offset to each timestamp we use in the tests.

@fnagel
Copy link
Member Author

fnagel commented Apr 8, 2017

@scottgonzalez I guess we want some central point to generate and modify Date objects and use that all over our code base, right? Something like a replacement for all new Date() usages.

Anyway, I would like to fix this in another PR and merge this, ok?

Did you notice Jon commented in the wiki?

@scottgonzalez
Copy link
Member

@scottgonzalez I guess we want some central point to generate and modify Date objects and use that all over our code base, right? Something like a replacement for all new Date() usages.

Yeah, we can put that in the helper file.

Anyway, I would like to fix this in another PR and merge this, ok?

That's fine with me.

Did you notice Jon commented in the wiki?

Yup, pretty much any time would work for me. Do you want to send out a doodle or similar request to find a good time?

@fnagel fnagel merged commit 7ef7f3a into jquery:datepicker Apr 11, 2017
@fnagel
Copy link
Member Author

fnagel commented Apr 11, 2017

@scottgonzalez

Ok, I've merged the PR and added a note in the wiki.

Regarding a Skype call: I've had lots of time in the beginning of the year but I'm about to move in two weeks. Not sure if I will find time to prepare and join a call. Might be possible you guys need to do this without me -- at least if we don't want to wait ages again. Discussing and adjusting the specs should be impossible without me too...

@mgol mgol added this to the 1.13 milestone Jun 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants