Fix line fetching in order creation #1956
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Thanks @maurice-ellis Are you able to provide a test case to show what this is fixing within it's context? |
|
@alecritson I added a test case. I believe I did that correctly. The issue is when you have 2 of the same purchasables, it causes an undefined key error in generating the breakdown because the line does not exist because the Not sure how to exactly test for that, but did create a case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm updating the line fetching in
Lunar\Pipelines\Order\Creation\CreateOrderLinesandLunar\Pipelines\Order\Creation\MapDiscountBreakdownto match the one used inLunar\Actions\Carts\GetExistingCartLineto see if the line meta matches as well.This PR will help be able to handle products when similar products are added instead of merged and quantity updated.