Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update groupdata of Picture-In-Picture API & some other update #35887

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

skyclouds2001
Copy link
Contributor

@skyclouds2001 skyclouds2001 commented Sep 14, 2024

Description

update groupdata of Picture-In-Picture API - remove non-existed guide, add missing interface and property, remove an event as the interface it belongs to has in the list already

rewrite value section of ShadowRoot.pictureInPictureElement

add PictureInPictureEvent to API interface list, and fixes in permissions-policy (seems to be conflict with fullscreen?)

Motivation

Additional details

Related issues and pull requests

relates to mdn/translated-content#23557

@github-actions github-actions bot added Content:WebAPI Web API docs size/s [PR only] 6-50 LoC changed labels Sep 14, 2024
Copy link
Contributor

github-actions bot commented Sep 14, 2024

@skyclouds2001 skyclouds2001 marked this pull request as ready for review September 14, 2024 06:45
@skyclouds2001 skyclouds2001 requested review from a team as code owners September 14, 2024 06:45
@skyclouds2001 skyclouds2001 requested review from Elchi3 and bsmth and removed request for a team September 14, 2024 06:45
@@ -71,7 +73,7 @@ The [`:picture-in-picture`](/en-US/docs/Web/CSS/:picture-in-picture) [CSS](/en-U

## Controlling access

The availability of picture-in-picture mode can be controlled using [Permissions Policy](/en-US/docs/Web/HTTP/Permissions_Policy). The fullscreen mode feature is identified by the string `"picture-in-picture"`, with a default allowlist value of `"self"`, meaning that picture-in-picture mode is permitted in top-level document contexts, as well as to nested browsing contexts loaded from the same origin as the top-most document.
The availability of picture-in-picture mode can be controlled using [Permissions Policy](/en-US/docs/Web/HTTP/Permissions_Policy). The picture-in-picture mode feature is identified by the string `"picture-in-picture"`, with a default allowlist value of `"*"`, meaning that picture-in-picture mode is permitted in top-level document contexts, as well as to nested browsing contexts loaded from the same origin as the top-most document.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should * be quoted? How does it appear in the header?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:WebAPI Web API docs size/s [PR only] 6-50 LoC changed
2 participants