Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Notification().silent default | update #35904

Merged
merged 6 commits into from
Sep 18, 2024

Conversation

skyclouds2001
Copy link
Contributor

Description

this is a follow up PR of #35714, which fix the default value in ServiceWorkerRegistration.showNotification()

see the detail at #35714, #31706, #26812 and spec PR at whatwg/notifications#194

and add additional detail to mdn/browser-compat-data#24276

Motivation

Additional details

Related issues and pull requests

@github-actions github-actions bot added Content:WebAPI Web API docs size/xs [PR only] 0-5 LoC changed labels Sep 16, 2024
Copy link
Contributor

github-actions bot commented Sep 16, 2024

Preview URLs

External URLs (2)

URL: /en-US/docs/Web/API/Notification/Notification
Title: Notification: Notification() constructor


URL: /en-US/docs/Web/API/ServiceWorkerRegistration/showNotification
Title: ServiceWorkerRegistration: showNotification() method

(comment last updated: 2024-09-18 16:20:22)

@skyclouds2001 skyclouds2001 marked this pull request as ready for review September 16, 2024 16:03
@skyclouds2001 skyclouds2001 requested a review from a team as a code owner September 16, 2024 16:03
@skyclouds2001 skyclouds2001 requested review from Elchi3 and removed request for a team September 16, 2024 16:03
@github-actions github-actions bot added size/s [PR only] 6-50 LoC changed and removed size/xs [PR only] 0-5 LoC changed labels Sep 18, 2024
@github-actions github-actions bot added size/m [PR only] 51-500 LoC changed and removed size/s [PR only] 6-50 LoC changed labels Sep 18, 2024
Copy link
Member

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've also done other changes:

  • Unify the wordings used for the options on the two API pages
  • Reorder and re-format the option lists
  • Update the exceptions part a bit

So syncing changes in the future should be more straightforward. I've not done any real content changes. Thanks for the PR.

@Josh-Cena Josh-Cena merged commit 09ad551 into mdn:main Sep 18, 2024
8 checks passed
@skyclouds2001 skyclouds2001 deleted the notification branch September 18, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:WebAPI Web API docs size/m [PR only] 51-500 LoC changed
2 participants