Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review #252 first, as it's a dependency for this PR.
Extends
H264SeqParameterSet
to parse the full descriptor (right now it's not parsing the VUI).I've basically adapted the code from nal-extractor:
https://github.com/medooze/nal-extractor/blob/main/lib/SPS.ts
https://github.com/medooze/nal-extractor/blob/main/test/SPS.test.ts
output for:
is:
For some reason
time_scale
says 61 rather than 60. I'll investigate later.